Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nextflow Support #4606

Merged
merged 19 commits into from
Nov 8, 2024
Merged

Add Nextflow Support #4606

merged 19 commits into from
Nov 8, 2024

Conversation

edmundmiller
Copy link
Contributor

Adding support for the new Nextflow Language Server.

https://seqera.io/blog/modernizing-nextflow-developer-experience/

Would love some feedback on anything to clean up. It also hangs whenever I try to download the lsp with lsp-install-server

@jcs090218
Copy link
Member

Can you update our CHANGELOG? Thanks! :D

@edmundmiller
Copy link
Contributor Author

Done! Thanks @jcs090218!

clients/lsp-nextflow.el Outdated Show resolved Hide resolved
clients/lsp-nextflow.el Outdated Show resolved Hide resolved
@jcs090218
Copy link
Member

Can you resolve the compile warnings? Thanks! :)

In toplevel form:
lsp-nextflow.el:84:2: Warning: custom-declare-variable `lsp-nextflow-files-exclude' docstring wider than 80 characters
lsp-nextflow.el:100:2: Warning: custom-declare-variable `lsp-nextflow-java-home' docstring wider than 80 characters

@edmundmiller
Copy link
Contributor Author

@jcs090218 Done, thank you!

@Lenbok
Copy link
Contributor

Lenbok commented Nov 6, 2024

It would be nice to get the server install working. I had to point the client at the jarfile manually downloaded. Surely since the jarfile is just a download from a GitHub release that should be straight forward? @jcs090218 ?

@edmundmiller
Copy link
Contributor Author

It would be nice to get the server install working. I had to point the client at the jarfile manually downloaded. Surely since the jarfile is just a download from a GitHub release that should be straight forward? @jcs090218 ?

I agree, but I think we can address that in a follow-up PR unless you have time to hack that out. I probably won't have time and would like to see this get merged before it gets stale.

@jcs090218
Copy link
Member

It would be nice to get the server install working. I had to point the client at the jarfile manually downloaded. Surely since the jarfile is just a download from a GitHub release that should be straight forward? @jcs090218 ?

I agree. It would be nice to have the server installation working, and it's indeed straightforward since I've done it a couple of times myself. :)

I agree, but I think we can address that in a follow-up PR unless you have time to hack that out. I probably won't have time and would like to see this get merged before it gets stale.

No problem! I would like to see smaller PRs since it's usually easier to build progress that way. 🤔

@jcs090218 jcs090218 merged commit 4f987cb into emacs-lsp:master Nov 8, 2024
11 of 13 checks passed
@jcs090218
Copy link
Member

Merged! Thank you for your contribution! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants