Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags are renamed in post-command-hook #10

Merged
merged 1 commit into from
May 20, 2020
Merged

Tags are renamed in post-command-hook #10

merged 1 commit into from
May 20, 2020

Conversation

aaronjensen
Copy link
Contributor

Fixes #9

This works better than what I posted in the issue. Give it a shot and see if it still works in all your scenarios.

@jcs090218
Copy link
Member

So what we do is place the function in post-command-hook instead of the after-changes-hook? I don't see strong objection to this! Merged this now! Thanks!

@jcs090218 jcs090218 merged commit 1c8d890 into emacs-vs:master May 20, 2020
@jcs090218 jcs090218 mentioned this pull request May 20, 2020
Open
@aaronjensen aaronjensen deleted the use-post-command-hook branch May 20, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp-mode with flycheck doesn't work.
2 participants
@aaronjensen @jcs090218