-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Numpy >=2.0 #1264
base: main
Are you sure you want to change the base?
Allow Numpy >=2.0 #1264
Conversation
I'm currently running the tests in a docker container |
I don't have an x86 machine handy right now, and running with mac ARM emulation is very slow (running for > 30 minutes) |
The issue is that |
@isaac-chung The tests should be good to rerun now |
Hmm looks like for python 3.9 and 3.10 numpy 2.0.0+ was installed in the tests. For Python 3.8, numpy 1.24 was installed, and "stable" doesn't seem to be a valid keyword for |
Looks like numpy 2.0 dropped support for Python 3.8 |
I think I am more for dropping support for 3.8 it is getting close to end-of-life anyway (end of this month). (@Muennighoff looping you in here as well) |
Ok, this isn't urgent so I'll probably just wait until Python 3.8 is dropped, then try to merge this as-is without a workaround |
Dropping Py3.8 now or later; either works w/ me |
Checklist
make test
.make lint
.Fixes #1263