Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update results for Alibaba-NLP/gte-modernbert-base #94

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

afalf
Copy link
Contributor

@afalf afalf commented Jan 21, 2025

Checklist

  • [ x ] Run tests locally to make sure nothing is broken using make test.
  • [ x ] Run the results files checker make pre-push.

Adding a model checklist

  • [ x ] I have added model implementation to mteb/models/ directory. Instruction to add a model can be found here in the following PR ____

@x-tabdeveloping
Copy link
Contributor

I believe the reason for the conflict is that #97 contains most of these. Can you try resolving the conflict and see if there is anything still missing from the repo? @afalf

@Samoed
Copy link
Collaborator

Samoed commented Jan 24, 2025

Results shouldn’t be in the external directory because that’s reserved for results from Hugging Face model cards. Your results should be placed in the directory corresponding to the model revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants