Add babel.config.js to .npmignore #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1010.
I may be wrong, followed emberjs/ember-cli-babel#418, ember-modifier/ember-modifier#102 and https://github.com/ember-modifier/ember-modifier/pull/101/files
My assumption is that addons should not ship
babel.config.js(at least yet).Also followed what Chris did with
buildEmberPlugins()instead of specifying only@babel/plugin-proposal-decoratorsplugin, I assume it just gives us some sort of safety net and be on pair with ember-cli-babel (at least from babel config perspective)