Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing-tools.md #2026

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Update testing-tools.md #2026

merged 3 commits into from
Jul 11, 2024

Conversation

Rashmi-N-Sahoo
Copy link
Contributor

Updated the Percy section.

@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited
Loading

✅ Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit fbecb61
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/668fbdf0739ebf00080a66b5
😎 Deploy Preview https://deploy-preview-2026--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IgnaceMaes
IgnaceMaes requested changes May 6, 2024
View reviewed changes
Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👍

We reworded it a bit to make the wording in line with our guides. Thanks for taking the time to update the Percy part of the documentation.

guides/release/testing/testing-tools.md Outdated Show resolved Hide resolved
Rashmi-N-Sahoo and others added 3 commits July 11, 2024 13:11
@Rashmi-N-Sahoo @MinThaMie
Update testing-tools.md
55a93be 
Updated the Percy section.
@Rashmi-N-Sahoo @MinThaMie
Update testing-tools.md
09770db 
Added Ember doc link.
@MinThaMie @IgnaceMaes
Update guides/release/testing/testing-tools.md
fbecb61 
Co-authored-by: Ignace Maes <[email protected]>
MinThaMie
MinThaMie approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :)

@MinThaMie MinThaMie merged commit 80d89b6 into ember-learn:master Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnaceMaes IgnaceMaes IgnaceMaes requested changes

@MinThaMie MinThaMie MinThaMie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rashmi-N-Sahoo @MinThaMie @IgnaceMaes