Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes not available in didRender #64

Open
simonihmig opened this issue Apr 22, 2019 · 0 comments
Open

Attributes not available in didRender #64

simonihmig opened this issue Apr 22, 2019 · 0 comments

Comments

@simonihmig
Copy link
Contributor

simonihmig commented Apr 22, 2019 •
edited
Loading

I ran into a strange issue, when refactoring ember-popper to support splattributes. Although the polyfill was added, tests fail for Ember 2.18, but passes for newer versions not requiring the polyfill (see kybishop/ember-popper#101, https://travis-ci.org/kybishop/ember-popper/builds/521966875).

I tracked this down to the attributes not being applied to the element at the time didRender is called (which causes other JS errors down the road as the component cannot find the DOM element by ID).

Here's a failing test: #65.
Fails for Ember < 3.4, passes for the newer ones with native support.
This was referenced Apr 22, 2019
Open
Merged
simonihmig added a commit to kybishop/ember-popper that referenced this issue Jun 8, 2019
@simonihmig
Use {{ref}} modifier to get the reference to the popper element, inst…
6c1b7c1 
…ead of querying by id

Should hopefully work around the timing issue of ember-polyfills/ember-angle-bracket-invocation-polyfill#64, and is more "octane-ish" anyway.
simonihmig added a commit to kybishop/ember-popper that referenced this issue Jun 8, 2019
@simonihmig
Use {{ref}} modifier to get the reference to the popper element, inst…
9fb8422 
…ead of querying by id

Should hopefully work around the timing issue of ember-polyfills/ember-angle-bracket-invocation-polyfill#64, and is more "octane-ish" anyway.
simonihmig added a commit to kybishop/ember-popper that referenced this issue Jun 8, 2019
@simonihmig
Use {{ref}} modifier to get the reference to the popper element, inst…
e7fe01c 
…ead of querying by id

Should hopefully work around the timing issue of ember-polyfills/ember-angle-bracket-invocation-polyfill#64, and is more "octane-ish" anyway.
@simonihmig simonihmig mentioned this issue Jun 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonihmig