Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support angle bracket invocation #101

Merged
merged 2 commits into from
Jun 8, 2019
Merged

Support angle bracket invocation #101

merged 2 commits into from
Jun 8, 2019

Conversation

simonihmig
Copy link
Collaborator

Propagates attributes using "splattributes".

Closes #98

@simonihmig
Copy link
Collaborator Author

Propagates attributes using "splattributes".

Closes #98
…ead of querying by id

Should hopefully work around the timing issue of ember-polyfills/ember-angle-bracket-invocation-polyfill#64, and is more "octane-ish" anyway.
@simonihmig
Copy link
Collaborator Author

Worked around the blocker now by not relying on querying for the popper element by ID in the DOM anymore, instead using a (even more octane-ish) {{ref}} modifier (https://github.com/lifeart/ember-ref-modifier).

@simonihmig simonihmig merged commit fe52a4b into master Jun 8, 2019
@simonihmig simonihmig deleted the angle-bracket branch June 8, 2019 15:07
@simonihmig
Copy link
Collaborator Author

Released as 0.10.0! /cc @kybishop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Angle Bracket Invocation
1 participant