Add ability to jump to source for functions and classes #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
add-inspect-value
branch
from
2056a8e to
b317b39
Compare
patricklx
force-pushed
the
add-inspect-value
branch
2 times, most recently
from
f9f0159 to
16e1d4f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
patricklx
force-pushed
the
add-inspect-value
branch
from
16e1d4f to
92dcd9e
Compare
patricklx
changed the title
patricklx
force-pushed
the
add-inspect-value
branch
2 times, most recently
from
b8048e3 to
cfc3f57
Compare
patricklx
force-pushed
the
add-inspect-value
branch
from
cfc3f57 to
eb3c382
Compare
patricklx
force-pushed
the
add-inspect-value
branch
2 times, most recently
from
478e182 to
cdb95b5
Compare
patricklx
force-pushed
the
add-inspect-value
branch
from
cdb95b5 to
ba10122
Compare
|
changed icon to a crosshair |
|
@RobbieTheWagner can you have a look? |
|
@patricklx sorry for the delay! This looks great, but could we please add some test coverage? I want to make sure everything merged in has robust tests, so we do not have regressions. |
patricklx
force-pushed
the
add-inspect-value
branch
from
05661fb to
7de56b5
Compare
patricklx
force-pushed
the
add-inspect-value
branch
from
7de56b5 to
4442f6c
Compare
RobbieTheWagner
approved these changes
Mar 11, 2024
|
Thank you for the PR @patricklx! This is a great feature. |
RobbieTheWagner
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this adds the action "goto source".
the behaviour is that it will call inspect on functions and classes which will show the source code of it.
It makes use of the existing function for dom node inspection. I only changed to name to be more generic (inspectJsValue)
this is ideal for going to a source of function or classes and set breakpoints for debugging
Screenshots