Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .get is not defined #2484

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix .get is not defined #2484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ember_debug/libs/promise-assembler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class PromiseAssembler extends BaseObject {
if (guid) {
const index = this.promiseIndex[guid];
if (index !== undefined) {
return this.all.get(index);
return this.all[index];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is never a proxy and won't need get ever? Could we add a small test to prevent regressions here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I missed this during the migration to native array wl

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's initalized here:
https://github.com/emberjs/ember-inspector/pull/2484/files#diff-c4248f1843d12b98763e8f64595e6a64fc1b4e6abe38ef9a538a08b88fb39fd0R28

}
} else {
return this.all;
Expand Down