Proposal: serialize remote nodes on in-element nodes to avoid dom exceptions #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sure someone else has more knowledge of how to fix this, but I wanted to put up the pr just to get the conversation started. All tests pass locally for me. |
|
I wonder if we actually need the remotes in the serialized tree? I do not remember anymore... |
I think I tried initially just deleting the |
patricklx
reviewed
Nov 16, 2023
mattmarcum
force-pushed
the
serialize-remotes
branch
from
b545a81 to
5ab784f
Compare
mattmarcum
force-pushed
the
serialize-remotes
branch
from
5ab784f to
ff245d2
Compare
patricklx
approved these changes
Nov 27, 2023
|
@mattmarcum can you fix the linting issues? then we could merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At my work we have a complex component that does direct dom manipluation and uses an in-element helper to boot. This caused the ember-inspector to crash with a dom exception error when trying to deepClone the render tree (dom nodes can not be deep cloned). Some debugging showed that the dom nodes were showing up in the
remotesarray of the in-element node, specifically in theboundsof the remote node items. Running those nodes through the same_serializeRenderNodesmethod kept ember-inspector from crashing.