improve in element support #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
improve-in-element
branch
11 times, most recently
from
d424212 to
10663a9
Compare
|
Thanks for the PR! @patricklx could we please write some tests to cover some of this? It all feels very brute force and I want to make sure we're covering our bases. |
|
@RobbieTheWagner we already have tests for it: I'm just improving it to be less hacky and then to support modifiers. I'm also implementing it in glimmer-vm. So maybe we can remove this code in the feature. I try to also get it into the older ember lts versions... |
patricklx
force-pushed
the
improve-in-element
branch
4 times, most recently
from
acdf5c9 to
4b1e942
Compare
patricklx
force-pushed
the
improve-in-element
branch
from
4b1e942 to
ec34a3b
Compare
RobbieTheWagner
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.