Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just in case #2592

Closed
wants to merge 1 commit into from
Closed

Just in case #2592

wants to merge 1 commit into from

Conversation

kategengler
Copy link
Member

Description

Screenshots

@RobbieTheWagner
Copy link
Member

All the tags seem to start with v so I am not sure if we need this. Probably wouldn't hurt, but I just wonder what would happen if for some reason we pushed an unrelated tag?

@kategengler
Copy link
Member Author

It would try to deploy on that tag if you had another. The absence of the v isn't the part I really want to try, it is the quoting of the thing. Per docs, it shouldn't affect it but I've seen it sometimes make a difference.

@RobbieTheWagner
Copy link
Member

@kategengler since we had a successful publish run, I would conclude this is unnecessary. Should we close it?

@RobbieTheWagner RobbieTheWagner deleted the kategengler-patch-1 branch July 27, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kategengler @RobbieTheWagner