Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[failing test] add test for adding/removing/re-adding modifier with if #20630

Open
wants to merge 1 commit into
base: lts-3-28
Choose a base branch
from
Open

[failing test] add test for adding/removing/re-adding modifier with if #20630

wants to merge 1 commit into from

Commits on Jan 25, 2024

  1. [failing test] add test for adding/removing/re-adding modifier with if 

    This test currently fails if the modifier is inside an `(if)` statement,
and if the condition changes from true -> false -> true.

It seems like somehow when the 3rd re-render to true happens, the `modifier`
helper gets a clone of the first two positional arguments (the event name and the
callback). The `modifier` helper gets 4 arguments when it should only be getting two.
    @fivetanley
    fivetanley committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e44b4d7 View commit details
    Browse the repository at this point in the history