Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (failing) tests for Query Parameter + Router Service related issues #20654

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nickschot
Copy link
Contributor

@nickschot nickschot commented Mar 5, 2024

This adds failing tests for at least 2 types of query parameter + router service related issues.

  • Ancestor model hooks are unnecessarily called if there is a query parameter with refresh: true and a default value
  • A query parameter transition happening during the afterModel of the initial transition will currently fail/crash. This happens both with and without a route specified.
  • A query parameter transition happening during the afterModel of followup transitions succeeds (same implementation, just not on the initial transition). This happens both with and without a route specified.

This includes the tests from #18579 since it seems closely related.

I may add more failing tests for cases as I encounter them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant