-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set type=module #92
base: main
Are you sure you want to change the base?
Set type=module #92
Conversation
Dude we're no where near being able to do this 😂 ember-cli is going to have such a hard time with the prebuild 😭 |
I had to know :p |
Looks like the first problem I run in to is that But renaming it to js, gives an error from ember-cli, as you predicted -- from but if I just inline what I need in (or we need more tests somewhere) |
@@ -1,3 +1,22 @@ | |||
import loadConfigFromMeta from '@embroider/config-meta-loader'; | |||
// import loadConfigFromMeta from '@embroider/config-meta-loader'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either this, or ember-cli, need to be made aware of the possibility of .cjs
extensions for config/environment
This is unexpected
|
do not merge (yet)