Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set type=module #92

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Set type=module #92

wants to merge 12 commits into from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Sep 28, 2024

do not merge (yet)

@mansona
Copy link
Member

mansona commented Sep 28, 2024

Dude we're no where near being able to do this 😂 ember-cli is going to have such a hard time with the prebuild 😭

@NullVoxPopuli
Copy link
Collaborator Author

I had to know :p

@NullVoxPopuli
Copy link
Collaborator Author

NullVoxPopuli commented Sep 28, 2024

Looks like the first problem I run in to is that loadConfigFromMeta from @embroider/config-meta-loader did not find the environment.cjs file.

But renaming it to js, gives an error from ember-cli, as you predicted -- from ember-cli/lib/models/project -- which makes sense as ember-cli magically looks for that file.

but if I just inline what I need in app/config/environment.js, it boots.... so I think we're actually really close, and we could have app type=module support with a lil'change to embroider 🤔

(or we need more tests somewhere)

@@ -1,3 +1,22 @@
import loadConfigFromMeta from '@embroider/config-meta-loader';
// import loadConfigFromMeta from '@embroider/config-meta-loader';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either this, or ember-cli, need to be made aware of the possibility of .cjs extensions for config/environment

@NullVoxPopuli
Copy link
Collaborator Author

This is unexpected

not ok 1 Firefox - [undefined ms] - error
Stderr: 
 Error: no DISPLAY environment variable specified

not ok 2 Edge - [undefined ms] - error
Stderr: 
 [2795:2795:0928/193403.938523:ERROR:ozone_platform_x11.cc(244)] Missing X server or $DISPLAY
 [2795:2795:0928/193403.938548:ERROR:env.cc(258)] The platform failed to initialize.  Exiting.
 
not ok 3 Chromium - [undefined ms] - error
  Stderr: 
   [2826:2826:0928/193405.322119:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants