Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JRuby 9.4.3.0 by default for gem and gemPush #144

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Use JRuby 9.4.3.0 by default for gem and gemPush #144

merged 1 commit into from
Sep 25, 2023

Conversation

dmikurube
Copy link
Member

@dmikurube dmikurube commented Sep 22, 2023 •
edited
Loading

It would not resolve #141 immediately (due to JRuby's issue), but anyway, we may want to use a newer version for gem and gemPush by default.

@dmikurube dmikurube added this to the v0.6.1 milestone Sep 22, 2023
@dmikurube dmikurube requested a review from a team as a code owner September 22, 2023 06:25
hiroyuki-sato
hiroyuki-sato approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Base automatically changed from bump-up-to-v0.6.1 to master September 25, 2023 01:58
@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 72d0db7 into master Sep 25, 2023
@dmikurube dmikurube deleted the jruby-9.4.3.0-by-default-for-gem branch September 25, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.

gemPush failed even $HOME/.gem/credential setting properly.
2 participants
@dmikurube @hiroyuki-sato