Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: Disable IME to fix backspace/arrow keys #5188

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Linux: Disable IME to fix backspace/arrow keys #5188

merged 1 commit into from
Sep 30, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Sep 30, 2024 •
edited
Loading

I suspect this will make IME no longer work on Linux, though I don't know if it ever worked.
I rather have backspace/arrows working though.

Please help test this (I don't have Linux!)

Tested on

  • Mac
  • Linux Wayland
  • Linux X11

@emilk emilk added bug Something is broken eframe Relates to epi and eframe egui-winit porblems related to winit native-linux Problem specific to Linux labels Sep 30, 2024
@emilk emilk added this to the Next Patch Release milestone Sep 30, 2024
@emilk emilk added the IME label Sep 30, 2024
@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5188-emilk/try-fix-linux-text-input
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@crumblingstatue
Copy link
Contributor

I tested it on Linux X11, and backspace and arrow keys are working in text inputs.

@emilk emilk merged commit 15d3d43 into master Sep 30, 2024
47 checks passed
@emilk emilk deleted the emilk/try-fix-linux-text-input branch September 30, 2024 11:23
@emilk emilk mentioned this pull request Sep 30, 2024
Open
@YgorSouza
Copy link
Contributor

Backspace and arrow keys working in Wayland as well, although they already worked before, and so did IME (e.g., compose key), which now no longer works of course.

@emilk emilk changed the title Fix backspace/arrow keys in TextEdit on Linux Disable IME to fix backspace/arrow keys on Linux Sep 30, 2024
@emilk emilk changed the title Disable IME to fix backspace/arrow keys on Linux Linux: Disable IME to fix backspace/arrow keys Sep 30, 2024
YgorSouza added a commit to YgorSouza/egui that referenced this pull request Sep 30, 2024
@YgorSouza
Revert "Fix backspace/arrow keys in TextEdit on Linux (emilk#5188)"
a72bdd7 
This reverts commit 15d3d43.
@YgorSouza YgorSouza mentioned this pull request Sep 30, 2024
Merged
1 task
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@emilk @hacknus
Fix backspace/arrow keys in TextEdit on Linux (emilk#5188)
9a69c2b 
* Closes emilk#5008
* Closes emilk#5182
* Bug introduced in emilk#4912

I suspect this will make IME no longer work on Linux, though I don't
know if it ever worked.
I rather have backspace/arrows working though.

Please help test this (I don't have Linux!)

# Tested on
* [x] Mac
* [ ] Linux Wayland
* [x] Linux X11
emilk pushed a commit that referenced this pull request Dec 31, 2024
@YgorSouza
Re-enable IME support on Linux (#5198)
3ffe1ed 
Reverts #5188 and adds a different fix to restore IME on Linux without
breaking the backspace and arrow keys.

* Closes #5544
* Closes #5198
* [x] I have followed the instructions in the PR template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something is broken eframe Relates to epi and eframe egui-winit porblems related to winit IME native-linux Problem specific to Linux
Projects
None yet
Milestone
Next Patch Release
Development

Successfully merging this pull request may close these issues.

eframe Linux: Backspace & arrow keys are completely broken
3 participants
@emilk @crumblingstatue @YgorSouza