-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support on hover tooltip that is noninteractable even with interactable content #5543
base: master
Are you sure you want to change the base?
Conversation
PPakalns
commented
Dec 29, 2024
- Closes Noninteractive tooltip with any content (on_hover_ui) #5519
- I have followed the instructions in the PR template
Tested in real use case. Greatly reduces flickering for "preview" tooltips that may contain interactable widgets. Use case: "Preview" of the page/window that will be opened if the button is pressed. |
Preview available at https://egui-pr-preview.github.io/pr/5543-noninteractivetooltip |
@emilk I ran into a related problem: rerun-io/rerun#8568 It seems like the current logic in In the case of the Rerun graph view, we can simply call |
942690e
to
ebbf493
Compare
Resolved conflicts. |
ebbf493
to
37240f1
Compare
Updated against newest master to rerun checks that failed due to incorrectly configured github pipeline action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the need for this functionality, but I think it's time to make a builder for tooltips so that we don't get this combinatorial explosion of tooltip methods
@emilk To make sure that I decide the right design for this, feel free to correct me: Currently we have methods:
And this PR wants to add parameter to configure if hover (tooltip) ui is interactable. I could replace these methods with one simple method:
Where HoverBuilder has configurable options:
Does this design seems OK? |