Code

Optimize editing multi-line text#5560

Code

Draft

emilk wants to merge 30 commits intomasteremilk/egui:masterfrom cache_galley_linesemilk/egui:cache_galley_linesCopy head branch name to clipboard

+396-141

Commits

Commits on Nov 28, 2024

• Fix typo

  afishhh

  committed
  622b848

  Copy full SHA for 622b848

• Cache individual lines of text in GalleyCache

  afishhh

  committed
  150c0f6

  Copy full SHA for 150c0f6

• Make Galleys share Rows and store their offsets

  afishhh

  committed
  db32a1e

  Copy full SHA for db32a1e

Commits on Nov 29, 2024

• Fix lints

  afishhh

  committed
  4e3f162

  Copy full SHA for 4e3f162

• Don't add leading space to more than one split layout section

  afishhh

  committed
  3de1723

  Copy full SHA for 3de1723

• Move cached-multiline-layout code into a helper function

  afishhh

  committed
  f028154

  Copy full SHA for f028154

• Properly handle row repositioning

  afishhh

  committed
  bc86bec

  Copy full SHA for bc86bec

Commits on Nov 30, 2024

• Correctly handle empty lines

  afishhh

  committed
  abbc561

  Copy full SHA for abbc561

• Respect first_row_min_height during multiline Galley layout

  afishhh

  committed
  6d6bc3b

  Copy full SHA for 6d6bc3b

• Round PlacedRow positions to pixels during multiline layout

  afishhh

  committed
  6147ff3

  Copy full SHA for 6147ff3

• Move ends_with_newline back into Row

  afishhh

  committed
  66c83c3

  Copy full SHA for 66c83c3

• Respect LayoutJob::round_output_size_to_nearest_ui_point

  afishhh

  committed
  1be24ba

  Copy full SHA for 1be24ba

• Simplify layout_multiline loop loop into a while loop

  afishhh

  committed
  fd8413c

  Copy full SHA for fd8413c

• Fix Row::ends_with_newline docs, explain skipping of last galley row

  afishhh

  committed
  bbe5662

  Copy full SHA for bbe5662

• Move some PlacedRow methods back to Row

  afishhh

  committed
  110a9c3

  Copy full SHA for 110a9c3

• Replace a hack with a proper implementation

  afishhh

  committed
  139f286

  Copy full SHA for 139f286

Commits on Dec 1, 2024

• Slightly simplify paint_text_selection code

  afishhh

  committed
  e15b34b

  Copy full SHA for e15b34b

Commits on Dec 4, 2024

• Fix nits

  afishhh

  committed
  c6592ec

  Copy full SHA for c6592ec

Commits on Dec 5, 2024

• Fix text horizontal alignment

  afishhh

  committed
  25da822

  Copy full SHA for 25da822

• Add comment and check for newline before multiline layout

  afishhh

  committed
  40f237d

  Copy full SHA for 40f237d

• Fix incorrect behavior with LayoutJob::max_rows

  afishhh

  committed
  17a5f1f

  Copy full SHA for 17a5f1f

Commits on Dec 7, 2024

• Merge branch 'emilk:master' into cache_galley_lines

  afishhh

  authored
  c094ee8

  Copy full SHA for c094ee8

Commits on Dec 11, 2024

• Add benchmark

  afishhh

  committed
  3e1ed18

  Copy full SHA for 3e1ed18

Commits on Dec 19, 2024

• Merge branch 'master' into cache_galley_lines

  afishhh

  authored
  ec9a408

  Copy full SHA for ec9a408

Commits on Dec 28, 2024

• Merge branch 'master' into cache_galley_lines

  emilk

  committed
  d2f75e9

  Copy full SHA for d2f75e9

Commits on Jan 2, 2025

• Better benchmark

  emilk

  committed
  2b53271

  Copy full SHA for 2b53271

• Merge branch 'master' into cache_galley_lines

  emilk

  committed
  ba2ae9d

  Copy full SHA for ba2ae9d

• Fix typos

  emilk

  committed
  7fb85d1

  Copy full SHA for 7fb85d1

• Split out long function

  emilk

  committed
  9fa294f

  Copy full SHA for 9fa294f

• cleanup

  emilk

  committed
  77c9fd8

  Copy full SHA for 77c9fd8