Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue processing item groups if one throws an error #662

Merged

Conversation

embeddedt
Copy link
Contributor

#631 introduced a regression that causes loading to fail completely if one item group throws an exception; this PR restores the try/catch around individual groups.

Duplication of the groupName logic is not ideal but I didn't think it was worth more refactoring to avoid it.

Copy link
Owner

@emilyploszaj emilyploszaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will technically throw down the line if a group doesn't populate the map but it'll be caught, which I suppose is fine. I'll make further adjustments myself, thanks for the contribution.

@emilyploszaj emilyploszaj merged commit d990140 into emilyploszaj:1.21 Aug 11, 2024
1 check passed
@embeddedt embeddedt deleted the ignore-item-group-exceptions branch August 11, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants