-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evidence - FeedbackEvaluator Storage & Basic UI #12758
Open
dandrabik
wants to merge
41
commits into
develop
Choose a base branch
from
feedback_evaluator_storage
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+577
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandrabik
changed the title
Evidence - FeedbackEvaluator Storage
Evidence - FeedbackEvaluator Storage & Basic UI
Jan 31, 2025
dandrabik
requested review from
brendanshean,
emilia-friedberg and
anathomical
January 31, 2025 22:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Run the FeedbackEvaluator after trials complete, store in a DB table and roll-up, show in UI.
WHY
We want to show this info in the UI of the research tool to make prompt engineering on the feedback prompt more efficient.
HOW
Create a new table
evidence_research_gen_ai_feedback_evaluations
and run evaluations when GEvalScores are calculated. Show in UI.Screenshots
### Notion Card Links
https://www.notion.so/quill/Feedback-Evaluation-Metrics-Storage-185d42e6f941807191e3ddc2da872cd7
What have you done to QA this feature?
I've run some tests locally in the console while connected to the staging DB. I also ran the metrics on staging and seemed to work properly. Viewed the UI locally to ensure the metrics show properly.