Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quill marking logic security upgrades #8625

Merged
merged 4 commits into from
Dec 21, 2021

Conversation

emilia-friedberg
Copy link
Member

WHAT

Security upgrades for quill-marking-logic.

WHY

We want to start the new year with all of our high-priority security issues fixed.

HOW

Just upgrade packages/remove entirely where possible and test. The only one I didn't address was webpack, which is actually only used for testing anyway - in order to keep the tests passing I would have had to upgrade karma-webpack to version 5.0.0, which is having issues on MacOS at the moment. The fix for these issues is already in master on their Github repository, so they should be coming out with 5.0.1 any day now and then we can upgrade: codymikol/karma-webpack#518.

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

https://www.notion.so/quill/Marking-Logic-High-Security-Package-Updates-5e0f19c365554bfe8a8b39dc7272098a

PR Checklist Your Answer
Have you added and/or updated tests? No, but manually tested to make sure things are still working
Have you deployed to Staging? YES
Self-Review: Have you done an initial self-review of the code below on Github? YES
Spec Review: Have you reviewed the spec and ensured this meets requirements and/or matches design mockups? N/A

@emilia-friedberg emilia-friedberg temporarily deployed to quill-lms-emilia December 17, 2021 14:52 Inactive
@emilia-friedberg emilia-friedberg merged commit c1b6e0c into develop Dec 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/quill-marking-logic-security-upgrades branch December 21, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants