-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 #85
Open
felixgirault
wants to merge
98
commits into
master
Choose a base branch
from
v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V3 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgirault
force-pushed
the
v3
branch
2 times, most recently
from
June 13, 2023 08:18
e8025d6
to
8ceb717
Compare
Hello, |
Hi, |
felixgirault
force-pushed
the
v3
branch
4 times, most recently
from
September 12, 2024 11:55
48b3072
to
0b4c213
Compare
felixgirault
force-pushed
the
v3
branch
3 times, most recently
from
September 13, 2024 16:44
b5d6f9a
to
dc28fdd
Compare
* preact * react-modal
Another option would have been to make every class name fully configurable (the whole class name instead of just the prefix), but the cost of it would outweigh the gain. Also, the `stylePrefix` option wasn't even documented, so we're betting on the fact that very few people are actually using it, if any.
This change is to better align with CNIL's recommendations. For now, the change has been made kind of brutally, so some things don't make sense (i.e. purposes can have purposes...). Further changes will fix the remaining problems.
This seems to be the most broadly used naming.
For now, they are just set to empty strings, but this allows to see what's missing at a glance.
The previous mechanics were overly complicated for such a small app, and pretty unlegible.
`tsup` was generating a custom type for each and every translation object, with all of their properties, resulting in a huge declaration. It turns out that `satisfies` does not impact the output, whereas `as` forces the `Translation` type to be used. We're still keeping the `satisfies` part, as it provides better typechecking (i.e. warning about missing or unknown properties).
* Folded the annotated configuration by default * Added details on theming
* fixed page markup * added missing styles * added a section in the doc
When running a dev server, renaming chunks doesn't work as expected.
HTML elements require dataset props to be camelCased.
When using React 18+, the app must be rendered using createRoot.
Events added by micromodal weren't properly unregistered, causing errors after closing a modal. Also, hiding the banner with `display: none` was preventing focus to be moved back to it after closing the modal.
* harmonized color names * fixed issues when closing modals by clicking the backdrop * fixed focus issue on toggle buttons (using `aria-disabled` instead of `disabled` prevents losing focus when the state changes)
@see RGAA 3.2
@see RGAA 9.3
@see RGAA 12.6
The link's title wasn't valid according to the RGAA. Instead of fixing it, we're removing the link altogether as it is of no real value. @see RGAA 6.1
@see RGAA 9.1
The differenciation was made by color only, there is now also a change in shape. @see RGAA 3.1
@see RGAA 11.5
We're deviating slightly from the official component styles so that buttons appear in the right order. @see https://www.systeme-de-design.gouv.fr/composants-et-modeles/composants/gestionnaire-de-consentement @see RGAA 12.8
Most texts were translated automatically from english, pending a better translation. @see RGAA 7.1
@see RGAA 7.1
Accessibility fixes
* using a page object to abstract things away * mocking an HTML page to load custom configs
End-to-end tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.