Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): fix the improper use of jest in avro and protobuf test cases #1755

Closed
wants to merge 0 commits into from

Conversation

LAST7
Copy link
Collaborator

@LAST7 LAST7 commented Sep 5, 2024

improve: improve readibility and code reuse in protobuf test cases
todo: three test cases failed due to unexpected behavior of protobuf.Type.verify, might need a discussion on this.

PR Checklist

Does this PR introduce a breaking change?

  • Yes
  • No

@LAST7
Copy link
Collaborator Author

LAST7 commented Sep 5, 2024

This PR is created to fix some issues in protobuf util unit tests. For more detail information, please refer to this blog.

@ysfscream ysfscream self-requested a review September 6, 2024 02:11
@ysfscream ysfscream added this to the v1.11.0 milestone Sep 6, 2024
@ysfscream ysfscream added fix Fix bug or issues test CLI MQTTX CLI labels Sep 6, 2024
@LAST7 LAST7 closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI fix Fix bug or issues test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants