Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a default(true) value for enable when creating rule #2986

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

zhongwencool
Copy link
Contributor

Every time a new rule is created, it is enabled by default, but there is no 'enable' field. So, let's add a default value. :)

This change has no impact on users; other fields (description, sql) have default values when creating a new rule, but this one does not, which feels a bit Inconvenient and inconsistent.

@ysfscream ysfscream merged commit 70db2e9 into emqx:dev/1.10.1 Sep 29, 2024
1 check passed
@ysfscream
Copy link
Member

Thanks 文哥 @zhongwencool 👍

@zhongwencool zhongwencool deleted the patch-1 branch September 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants