fix: prevent replicants from joining core nodes that disabled node discovery #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scovery Core node may leave a cluster and disable discovery. In this case, replicants must ignore (don't connect to) this node.
ieQu1
approved these changes
Apr 9, 2024
ieQu1
reviewed
Apr 9, 2024
| @@ -61,6 +61,9 @@ | |||
| , db_nodes => [node()] | |||
| , shard_badness => [{mria_rlog:shard(), float()}] | |||
| , custom_info => _ | |||
| %% We can't prevent core node discovery if the node is still up and reachable. | |||
| %% Thus, a replicant can discover a core but must ignore it if discovery is disabled. | |||
| , discovery_enabled => boolean() | |||
There was a problem hiding this comment.
Alternatively, it can just return something like undefined?
There was a problem hiding this comment.
Yes, but I've set the default to true everywhere already..., e.g.:
is_core_node_discovery_enabled() ->
application:get_env(mria, core_node_discovery, true).
Please let me know if you prefer to change it..
SergeTupchiy
added a commit
to SergeTupchiy/ekka
that referenced
this pull request
Apr 9, 2024
Included updates: - emqx/mria#178
SergeTupchiy
added a commit
to SergeTupchiy/ekka
that referenced
this pull request
Apr 9, 2024
Included updates: - emqx/mria#178
SergeTupchiy
added a commit
to SergeTupchiy/emqx
that referenced
this pull request
Apr 9, 2024
Included updates: - emqx/mria#178
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core node may leave a cluster and disable discovery. In this case, replicants must ignore (don't connect to) this node.