Only serialize modified settings. NFC #23648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #23647 |
sbc100
force-pushed
the
limit_settings
branch
3 times, most recently
from
c44c3b8 to
3fb7030
Compare
kripken
reviewed
Feb 11, 2025
This means that when we run the compiler or the preprocessor we don't serialize all setting to JSON, only setting that were are set to something other than the default.
sbc100
force-pushed
the
limit_settings
branch
from
3fb7030 to
650b6b9
Compare
kripken
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that when we run the compiler or the preprocessor we don't serialize all setting to JSON, only setting that were are set to something other than the default.