Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no ENABLE_EEPROM_SETTINGS is used in MakeFile, a 0 byte eeprom is generated #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tned73
Copy link

@tned73 tned73 commented Nov 3, 2017

Without the Makefile setting
SETTINGS += -DENABLE_EEPROM_SETTINGS
The application still reads the EEPROM for default settings and the LogInit function still uses EEPROM.

Due to the worn out EEPROM of my xmega, I wanted to run the application without a single EEPROM read or write.

This branch makes the .eep file has 0 bytes to write and every thing still works.

The LogInit function is now horrible, can't figure out why there needs to be a EEPROM read and write. but I have no working EEPROM, so I can't test a rewrite.

@skuep
Copy link
Collaborator

skuep commented Nov 3, 2017

I think a better solution to this problem is to add a new command to the chameleon command line, e.g. "SETTING_STORAGE=OFF" that is set to ON automatically on every startup by default. It prevents the eeprom from being updated on setting change. This could be easily Integrated into any automated script.
Other options would be "INTERACTIVE_MODE=ON" or SCRIPT_MODE=ON"

@tned73
Copy link
Author

tned73 commented Nov 3, 2017

That is a nicer solution. This patch only fixes some points with the existing Makefile parameter. The parameter implies that you can use eeprom, so if you don't, now there is no eeprom used.

De Command line option and this fix are not mutely exclusive, both can be implemented at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants