Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tokens for Utility Menu #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Design tokens for Utility Menu #155

wants to merge 3 commits into from

Conversation

mariannuar
Copy link
Collaborator

Summary

Design tokens for the new Utility Menu component

How to review this pull request

  • To review, confirm that Utility Menu component exists and it has design tokens in Emulsify UI Kit

@mariannuar mariannuar self-assigned this Sep 5, 2024
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit f772281
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/66da31fca3517d0008a1abea
😎 Deploy Preview https://deploy-preview-155--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Similar to your tooltip PR. Can you switch this to the convert-components-to-sdc branch and verify only the changes to the currently listed files apply? I'm guessing you may also run into a lot of unintended files changes as well.

@callinmullaney callinmullaney added 👉 Needs Work Reviewer has requested changes. and removed 👍 Ready for Review Work is ready for review. labels Sep 10, 2024
@mariannuar mariannuar changed the base branch from main to convert-components-to-sdc September 17, 2024 20:29
@mariannuar mariannuar added 👍 Ready for Review Work is ready for review. and removed 👉 Needs Work Reviewer has requested changes. labels Sep 17, 2024
Base automatically changed from convert-components-to-sdc to main October 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for Review Work is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants