Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-19494: css-loader v7 migration #306

Open
wants to merge 1 commit into
base: feature/enact_v5
Choose a base branch
from

Conversation

hong6316
Copy link

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

css-loader v7 migration
https://github.com/webpack-contrib/css-loader/releases/tag/v7.0.0

Resolution

Change import style

// Before
import style from "./style.css";

//After
import * as style from "./style.css";

Additional Considerations

  • Those changes should be descripted on migration guide, if decided to merge.
  • Those changes should be synced with tools including css-loader v7(cli, storybook-utils)

Links

WRQ-19494

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

@hong6316 hong6316 deleted the branch feature/enact_v5 May 30, 2024 06:01
@hong6316 hong6316 closed this May 30, 2024
@hong6316 hong6316 reopened this Jun 19, 2024
@hong6316 hong6316 changed the base branch from feature/node18 to feature/enact_v5 June 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant