Minor UCVAPD test improvement

enbility · Feb 25, 2024 · 577b756 · 577b756
1 parent 12a5784
commit 577b756
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/ucvapd/events.go b/ucvapd/events.go
@@ -95,7 +95,9 @@ func (e *UCVAPD) inverterConfigurationDescriptionDataUpdate(entity spineapi.Enti
 func (e *UCVAPD) inverterConfigurationDataUpdate(ski string, entity spineapi.EntityRemoteInterface) {
 	// Scenario 1
 	if deviceConfiguration, err := util.DeviceConfiguration(e.service, entity); err == nil {
-		if _, err := deviceConfiguration.GetKeyValueForKeyName(model.DeviceConfigurationKeyNameTypePeakPowerOfPVSystem, model.DeviceConfigurationKeyValueTypeTypeScaledNumber); err == nil {
+		if _, err := deviceConfiguration.GetKeyValueForKeyName(
+			model.DeviceConfigurationKeyNameTypePeakPowerOfPVSystem,
+			model.DeviceConfigurationKeyValueTypeTypeScaledNumber); err == nil {
 			e.eventCB(ski, entity.Device(), entity, DataUpdatePowerNominalPeak)
 		}
 	}

diff --git a/ucvapd/events_test.go b/ucvapd/events_test.go
@@ -39,6 +39,42 @@ func (s *UCVAPDSuite) Test_Events() {
 	s.sut.HandleEvent(payload)
 }
 
+func (s *UCVAPDSuite) Test_inverterConfigurationDataUpdate() {
+	s.sut.inverterConfigurationDataUpdate(remoteSki, s.pvEntity)
+
+	descData := &model.DeviceConfigurationKeyValueDescriptionListDataType{
+		DeviceConfigurationKeyValueDescriptionData: []model.DeviceConfigurationKeyValueDescriptionDataType{
+			{
+				KeyId:     eebusutil.Ptr(model.DeviceConfigurationKeyIdType(0)),
+				KeyName:   eebusutil.Ptr(model.DeviceConfigurationKeyNameTypePeakPowerOfPVSystem),
+				ValueType: eebusutil.Ptr(model.DeviceConfigurationKeyValueTypeTypeScaledNumber),
+			},
+		},
+	}
+
+	rFeature := s.remoteDevice.FeatureByEntityTypeAndRole(s.pvEntity, model.FeatureTypeTypeDeviceConfiguration, model.RoleTypeServer)
+	fErr := rFeature.UpdateData(model.FunctionTypeDeviceConfigurationKeyValueDescriptionListData, descData, nil, nil)
+	assert.Nil(s.T(), fErr)
+
+	s.sut.inverterConfigurationDataUpdate(remoteSki, s.pvEntity)
+
+	data := &model.DeviceConfigurationKeyValueListDataType{
+		DeviceConfigurationKeyValueData: []model.DeviceConfigurationKeyValueDataType{
+			{
+				KeyId: eebusutil.Ptr(model.DeviceConfigurationKeyIdType(0)),
+				Value: &model.DeviceConfigurationKeyValueValueType{
+					ScaledNumber: model.NewScaledNumberType(10),
+				},
+			},
+		},
+	}
+
+	fErr = rFeature.UpdateData(model.FunctionTypeDeviceConfigurationKeyValueListData, data, nil, nil)
+	assert.Nil(s.T(), fErr)
+
+	s.sut.inverterConfigurationDataUpdate(remoteSki, s.pvEntity)
+}
+
 func (s *UCVAPDSuite) Test_inverterMeasurementDataUpdate() {
 	s.sut.inverterMeasurementDataUpdate(remoteSki, s.pvEntity)