-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDT Support #123
base: dev
Are you sure you want to change the base?
MDT Support #123
Conversation
Thanks a lot for this PR! The changes and additions look good so far. Would it be possible to get a SPINE trace log to see the communication in action? That would be the best source for me to evaluate the actual implementation. Additionally I started adding comments to the |
Sure ill try to get these for you Any thoughts about adding something like this to the lower comms level? A flag that can be set to allow saving rx/tx packets to a file for logging? |
I am not sure I understand your question. Could you elaborate a bit more on that please? (You can also join the Slack channel for such discussions, linked in the enbility.net contact page) |
A feature that would allow saving of the incoming and outgoing packets to a file, for later inspection. It would be great for debugging purposes especially as due to the encryption tcpdump is pretty useless |
That's imho already possible by implementing the logging interface and writing that output to a file. See https://github.com/enbility/eebus-go/blob/dev/examples/hems/main.go#L96 and https://github.com/enbility/eebus-go/blob/dev/examples/hems/main.go#L322-L368 |
MDT tested with a Vailant heatpump