-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add httpx.SSLContext
configuration.
#3022
Add httpx.SSLContext
configuration.
#3022
Conversation
897a5de
to
88f2ab7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Yes, I agree that removing them completely is not what the user expects. Or should we deprecate them anyway? Not obvious to me. |
This comment was marked as resolved.
This comment was marked as resolved.
Looking good.
I'd suggest you don't spin time on that until we've had a clear discussion around the "API finessing" and "Documentation refresh" areas mentioned in #947 (comment). I like this change, but we'll want to make it as part of a coherent & consistent 1.0 refresh. |
httpx.SSLContext
configuration.
Okay, shall we take the docs from this comment... #3007 (comment) and include them in the PR? |
I like it |
Have we decided to remove or deprecate the old arguments? |
Co-authored-by: T-256 <[email protected]>
Dropping `trust_env` from `httpx.SSLContext()` API.
Thanks so much @karpetrosyan - going to merge this into "version-1.0" now, and then apply remaining changes incrementally. Fantastic work!! 😎 |
Sorry, I couldn't find time to finish all the tidy-ups. |
Thank you so much for your time & dedication @karpetrosyan. 🙌 |
Discussed in #3007
TODO:
Migration examples
Enabling and disabling verification
Use a different set of certificates
Client side certificates
Using alternate SSL contexts