Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move utility functions from _utils.py to _multipart.py #3388

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Move utility functions from _utils.py to _multipart.py #3388

merged 1 commit into from
Nov 1, 2024

Conversation

RafaelWO
Copy link
Contributor

@RafaelWO RafaelWO commented Nov 1, 2024 •
edited
Loading

Summary

Related issue: #3381

This PR moves the following utility functions from _utils.py to _multipart.py that are only used in _multipart.py

  • format_form_param
  • guess_content_type

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@RafaelWO
♻️ Move functions from _utils.py to _multipart.py
d51b76a 
The following functions are moved because they are only used in _multipart.py
* format_form_param
* guess_content_type
tomchristie
tomchristie approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RafaelWO 😎

@tomchristie tomchristie merged commit 6212e8f into encode:master Nov 1, 2024
5 checks passed
@RafaelWO RafaelWO deleted the change/move-utils-to-multipart branch November 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RafaelWO @tomchristie