Implement multi-column constraints. #73
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created for #72.
This allows for the pass-through of table arguments to the underlying sqlalchemy table. In particular, the passing of
UniqueConstraint
.This PR should not be considered complete, but requesting input. Two subjects of particular concern are:
UniqueConstraint
fromsqlalchemy.schema
when used. Is this fine? Theoretically this multi-column uniqueness shouldn't be as prevalent as single column uniqueness (which only requires passingunique=True
). Thus, perhaps it makes sense to necessitate directly reference to sqlalchemy in these rare cases.from sqlite3 import IntegrityError
. This is what I used because the exception raised byaiosqlite
is not encapsulated byfrom sqlalchemy.exc import IntegrityError
. Thus, I question how to deal with the issue thataiosqlite
'sIntegrityError
isn't being caught using a cross-DB solution.More on the second point, I don't know if that means I should open up an issue with
aiosqlite
.