Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCORE Environment - Beta Authoring and Roomcasting #660

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

JoelWiebe
Copy link
Contributor

@JoelWiebe JoelWiebe commented Feb 11, 2025

Details

  • Added roomcasting component, logic, and socket connections
  • Modified canvas, buckets, workspace, and monitor to also read active route properties from Input() properties (from html element)
  • Added SCORE Authoring emits RESOURCES_UPDATED but listening in SCORE Roomcasting Environment is not yet complete
  • Created AI Agent model, AI Agent class, sub-class agents, ai-agent configuration file, and modal in score-authoring for authoring AI agent subc
    lasses in an activity
  • Set Teacher Tasks as an expandable module in SCORE authoring
  • Added show join code teacher task; Set all teacher tasks as clickable
  • Added implementation of activate workflow and custom prompt teacher tasks to SCORE authoring dashboard
  • Added display of CK Monitor and CK workspace within the SCORE authoring/orchestration environment
  • Fixed resizing of canvas in SCORE view modal; Removed heading from bucket view in SCORE view modal; Removed CK Buckets heading from bucket view
  • Renamed Activities to Activity Phases in activity pane
  • Added bucket and workflow editing to SCORE authoring
  • Added View Canvas as an additional teacher task and created SCORE view modal for displaying other components;
  • Added support for opening the canvas in the SCORE view modal;
  • Added SCORE authoring links for editing groups, activity groups, and board configurations
  • Added and styled teacher activity list for SCORE authoring; Minor styling and header changes; Temporarily removed button for Classroom Authoring
  • Added a classroom canvas for SCORE authoring; Added a classroom objects resource pane; Added grid layout and classroom outline that supports dynamic resizing
  • Added group to resource assignment logic and UI
  • Add edit activity component; Add deleting and updating activities; Add associated activity space name to activity title
  • Created a Resources model, api routing, and database calls; Added resources list to activities, created with drag and drop from available resources pane
  • Added reordering of activities to frontend, backend, and styling
  • Add resources as the means of assigning views (e.g., canvas, workspace, etc.) to activities
  • Fixed adding and fetching activities from DB
  • Added SCORE Authoring page and routing;
  • Added add activity modal with populated board and group selects;
  • TODO fix save and retrieve activities to/form DB
  • Rename Boards to Activity Spaces on project dashboard; Add Script SCORE Run button to SCORE Run dashboard
  • Separate SCORE Runs and CK Projects in projects dashboard
  • Created new isScoreRun property for CK projects;
  • Added menu item and modal for creating SCORE Runs

Test

  • Create a new SCORE Run (rather than a standalone CK Board Project) from the project dashboard -> Should shown up under a SCORE Run heading
  • Can create and delete Activity Phases in a SCORE Run
  • Can edit Activity Phases
  • Click the plus button in bottom right of screen to drag resources onto the resource assignments pane (small bug, can actually drag anywhere and it still works)
  • Click buttons to assign resources to groups
  • Drag Teacher Actions to Teacher Tasks pane
  • View Canvas, Bucket, Workspace, and Monitor in Teacher Tasks should display in modal popup
  • Clicking play button beside Activity in Activity Phases should emit data
  • TODO: Web socket is not received by roomcasting environment (I used a basic, simplified implementation of web sockets but never got it working) -- Please feel free to reimplement to get sockets working :)
  • Click on Open Roomcasting Environment in left pane should navigate to /roomcast

Closes #593

… populated board and group selects; TODO fix save and retrieve activities to/form DB
…ources list to activities, created with drag and drop from available resources pane
…d associated activity space name to activity title
…ts resource pane; Added grid layout and classroom outline that supports dynamic resizing
…ling and header changes; Temporarily removed button for Classroom Authoring
…w modal for displaying other components; Added support for opening the canvas in the SCORE view modal; Added SCORE authoring links for editing groups, activity groups, and board configurations
…cket view in SCORE view modal; Removed CK Buckets heading from bucket view
…nfiguration file, and modal in score-authoring for authoring AI agent subclasses in an activity
…canvas, buckets, workspace, and monitor to also read active route properties from Input() properties (from html element); Added SCORE Authoring emits RESOURCES_UPDATED but listening in SCORE Roomcasting Environment is not yet complete
@JoelWiebe JoelWiebe linked an issue Feb 11, 2025 that may be closed by this pull request
13 tasks
Copy link
Contributor

@markiianbabiak markiianbabiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Got a console error when clicking on the view bucket in the teacher actions, same with view personal workspace and the one that opens monitor view.
board.service.ts:15 ERROR Error: Uncaught (in promise): TypeError: Cannot read properties of undefined (reading 'subscribe')

TypeError: Cannot read properties of undefined (reading 'subscribe')
    at ck-buckets.component.ts:80:36
    at Generator.next (<anonymous>)
    at CkBucketsComponent.ngOnInit (ck-buckets.component.ts:94:64)
    at ck-buckets.component.ts:80:36
    at Generator.next (<anonymous>)
    at CkBucketsComponent.ngOnInit (ck-buckets.component.ts:94:64)
    at CkBucketsComponent.ngOnInit (ck-buckets.component.ts:94:64).

and

core.mjs:8400 ERROR TypeError: Cannot read properties of undefined (reading 'boardID')
    at CkMonitorComponent.ngOnDestroy (ck-monitor.component.ts:641:64)
  • Workspace also has this console error:
 ERROR TypeError: Cannot read properties of undefined (reading 'boardID')
    at CkWorkspaceComponent.ngOnDestroy (ck-workspace.component.ts:633:64)
  • Also, when building frontend got this warning:
Warning: src/app/components/ck-buckets/ck-buckets.component.html:15:14 - warning NG8107: The left side of this optional chain operation does not include 'null' or 'undefined' in its type, therefore the '?.' operator can be replaced with the '.' operator.

15       board?.scope === BoardScope.PROJECT_SHARED
                ~~~~~

  src/app/components/ck-buckets/ck-buckets.component.ts:25:16
    25   templateUrl: './ck-buckets.component.html',
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Error occurs in the template of component CkBucketsComponent.

  • When I opened the monitor view with no tasks. It was showing the loading animation non-stop.
  • I am not sure what was the reason, but the whole page just got half frozen with buttons being unclickable, there were no console logs during that.

@JoelWiebe
Copy link
Contributor Author

Thanks, I'll take a look at these and add a few more items.

@markiianbabiak
Copy link
Contributor

I think should be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Create SCORE Runs
2 participants