Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trading panel extension and embedded button of #8848 #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

trading panel extension and embedded button of #8848 #140

wants to merge 2 commits into from

Conversation

UnorderedSigh
Copy link
Contributor

@UnorderedSigh UnorderedSigh commented Jun 8, 2023 •
edited
Loading

Two new UI elements:

  1. An extension to the lower-right corner of the planet panel for trading.
  2. A button intended to be embedded within a panel, instead below it.

Main PR is here: endless-sky/endless-sky#8848
2x res is here: endless-sky/endless-sky-high-dpi#366

This was referenced Jun 8, 2023
Open
Open
xobes
xobes suggested changes Nov 23, 2024
View reviewed changes
Copy link

@xobes xobes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It's not clear to me which of these is actually used to produce the two files that are in the 1x and 2x repositories.
  2. There is no .svg file for the new features.
  3. Do you need help making these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xobes xobes xobes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnorderedSigh @xobes