Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/wayland backend #29

Merged
merged 46 commits into from
Nov 20, 2023
Merged

Feature/wayland backend #29

merged 46 commits into from
Nov 20, 2023

Conversation

eneoli
Copy link
Owner

@eneoli eneoli commented Nov 12, 2023 •
edited
Loading

Fixes #4

@TornaxO7 TornaxO7 self-requested a review November 13, 2023 00:32
@TornaxO7 TornaxO7 linked an issue Nov 13, 2023 that may be closed by this pull request
Screenshotting Wayland #4
Closed
@eneoli eneoli changed the title DRAFT: Feature/wayland backend Feature/wayland backend Nov 18, 2023
@eneoli eneoli marked this pull request as ready for review November 18, 2023 03:39
TornaxO7
TornaxO7 requested changes Nov 18, 2023
View reviewed changes
src/backend/wayland/mod.rs Outdated Show resolved Hide resolved
src/backend/wayland/mod.rs Outdated Show resolved Hide resolved
src/backend/wayland/mod.rs Outdated Show resolved Hide resolved
src/backend/wayland/mod.rs Outdated Show resolved Hide resolved
src/backend/wayland/mod.rs Outdated Show resolved Hide resolved
src/backend/wayland/wayland_output_mode.rs Outdated Show resolved Hide resolved
src/backend/wayland/wayland_screenshot_state.rs Show resolved Hide resolved
src/backend/wayland/wayland_screenshot_state.rs Outdated Show resolved Hide resolved
src/backend/wayland/wayland_screenshot_state.rs Outdated Show resolved Hide resolved
src/backend/wayland/wayland_shared_memory.rs Outdated Show resolved Hide resolved
@eneoli eneoli requested a review from TornaxO7 November 20, 2023 01:48
TornaxO7
TornaxO7 requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little suggestions.

src/backend/wayland/mod.rs Outdated Show resolved Hide resolved
src/backend/wayland/wayland_screenshot_state.rs Show resolved Hide resolved
TornaxO7
TornaxO7 previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:peepoYes:

TornaxO7
TornaxO7 previously approved these changes Nov 20, 2023
View reviewed changes
@eneoli
cleanup
93071b5
@eneoli
Merge remote-tracking branch 'origin/feature/wayland-backend' into fe…
aa11bbd 
…ature/wayland-backend

# Conflicts:
#	src/backend/wayland/mod.rs
TornaxO7
TornaxO7 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peepoPray

@eneoli eneoli merged commit eb2a02c into main Nov 20, 2023
1 check passed
@eneoli eneoli deleted the feature/wayland-backend branch November 20, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TornaxO7 TornaxO7 TornaxO7 approved these changes

Assignees

@eneoli eneoli

Labels
None yet
Projects
None yet
Milestone
Iteration 1: Backend implementation
Development

Successfully merging this pull request may close these issues.

Screenshotting Wayland
2 participants
@eneoli @TornaxO7