Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Drawable framework + cropping #88

Merged
merged 54 commits into from
Feb 5, 2024
Merged

Basic Drawable framework + cropping #88

merged 54 commits into from
Feb 5, 2024

Conversation

eneoli
Copy link
Owner

@eneoli eneoli commented Jan 27, 2024 •
edited
Loading

Things added:

  • basic drawable framework for creating widgets with ease
  • cropping functionality
  • tool selection
  • some bug fixes

Closes #64
Closes #92

@eneoli eneoli self-assigned this Jan 27, 2024
@eneoli eneoli changed the title Feature/cropping Basic Drawable framework + cropping Jan 28, 2024
@eneoli eneoli requested a review from TornaxO7 February 3, 2024 23:33
@eneoli eneoli mentioned this pull request Feb 4, 2024
Open
@eneoli
Copy link
Owner Author

eneoli commented Feb 4, 2024

@TornaxO7 there were errors in the X11 screenshot backend. You might want try it again now.

@TornaxO7
Copy link
Collaborator

TornaxO7 commented Feb 4, 2024

Nice one!
But I've still got some issues.

  • In all the layouts below HDMI is my main monitor.
  • I've executed cargo run -- gui on my main monitor.

Extending cropping to second monitor isn't visible

Layout:
image

If I try to extend the cropping selection between two monitors, then it'll look like this:
image

Setting second monitor vertical creates wrong image placing

Layout:
image

Gives me this:
image

To be fair, we can apply a fix for this in another PR. What do you think?

TornaxO7
TornaxO7 requested changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol things only

src/backend/x11.rs Show resolved Hide resolved
src/frontend/ui/tool_manager.rs Outdated Show resolved Hide resolved
src/frontend/window/main_window.rs Outdated Show resolved Hide resolved
src/frontend/shape/rectangle.rs Outdated Show resolved Hide resolved
@eneoli
Copy link
Owner Author

eneoli commented Feb 4, 2024

  • Does the cropping area appear after stopping moving the mouse or releasing the mouse?
  • This might be correct. We create a rectangular canvas based on the added width and height of all monitors. Is it normal that your left screen is black?

@eneoli
Copy link
Owner Author

eneoli commented Feb 5, 2024

Blocked until gtk-rs/gtk4-rs#1597 resolved...

TornaxO7
TornaxO7 requested changes Feb 5, 2024
View reviewed changes
src/frontend/window/main_window.rs Outdated Show resolved Hide resolved
@TornaxO7 TornaxO7 self-requested a review February 5, 2024 22:04
@TornaxO7 TornaxO7 merged commit 644fe69 into main Feb 5, 2024
1 check passed
@TornaxO7 TornaxO7 deleted the feature/cropping branch February 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TornaxO7 TornaxO7 TornaxO7 approved these changes

Assignees

@eneoli eneoli

Labels
None yet
Projects
None yet
Milestone
Iteration 2: Core functionality
Development

Successfully merging this pull request may close these issues.

X11: Windows created on the same monitor Basic Drawable framework + Cropping functionality
2 participants
@eneoli @TornaxO7