Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for unreactive react keys #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NoodleOfDeath
Copy link

@NoodleOfDeath NoodleOfDeath commented Jul 4, 2023

Summary

This addresses

MenuItems uses an numeric index for reactive keys, so react has no idea that the item needs to be recomputed when the arrow function differs between two items but all other properties are the same. This should be exposed to the developers and required to prevent the side effect of the first onPress arrow function persisting for all items that only differ by their onPress property.

@ansh
Copy link

ansh commented Jul 6, 2023

This should be merged ASAP. @enesozturk

@kesha-antonov
Copy link
Contributor

Need this also 🙏🙏🙏
@enesozturk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants