Skip to content

Commit

Permalink
Replace scss lint to remove bundler dependency and switch ThemeKit to…
Browse files Browse the repository at this point in the history 
… slate-cli (Shopify#351)

* change themekit commands to slate

* replace scss lint gem with node scss lint

* remove unsupported scss lint rule

* fix sass-lint rules naming on inline enable

* switch sass linting to shopify fork

* update sass-lint dependency to latest
  • Loading branch information
Ryan Macdonald authored Jun 30, 2016
1 parent 11653ff commit db879f4
Show file tree
Hide file tree
Showing 12 changed files with 436 additions and 699 deletions.
311 changes: 87 additions & 224 deletions .scss-lint.yml
View file
Original file line number Diff line number Diff line change
@@ -1,224 +1,87 @@
---

scss_files:
- 'src/styles/**/*.scss'
- 'src/styles/*.scss'
exclude:
- 'src/styles/settings/*.scss.liquid'
- 'src/styles/vendor/**/*.scss'
- 'src/styles/vendor/*.scss'

linters:
# Border 0 required when enabled
BorderZero:
enabled: true

CapitalizationInSelector:
ignored_types: id

# Prefer hexadecimal color codes over color keywords.
# Good argument here wrt to it being easier to search/replace if only one is used
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#colorkeyword
ColorKeyword:
enabled: true

# Force colors to be stored in variables
# https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#colorvariable
ColorVariable:
enabled: true

# Our FED style guide calls for using /* ... */ style comments
# https://vault.shopify.com/Front-End-Development/Style-Guide#_table-of-contents_before-you-start_code-style_html_css-architecture_naming-conventions_scss-architecture_syntax-spacing_shorthands_commenting
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#comment
Comment:
enabled: false

# did you forget a @debug?
DebugStatement:
enabled: true

# Move @extend to top of a style
# enforce @extend and @include declaration order
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#declarationorder
DeclarationOrder:
enabled: false

# Won’t work if we’re adding rgb fallbacks for example
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#duplicateproperty
DuplicateProperty:
enabled: false

# As per styleguide
ElsePlacement:
enabled: true
style: same_line

EmptyLineBetweenBlocks:
enabled: true
ignore_single_line_blocks: false

# No empty rules
EmptyRule:
enabled: true

FinalNewline:
enabled: true

# #fff or #ffffff
HexLength:
enabled: true
style: short

# #fff or #FFF
HexNotation:
enabled: true
style: lowercase

# Checks that hex codes are valid
HexValidation:
enabled: true

# IDs as selectors
# https://github.com/brigade/scss-lint/tree/master/lib/scss_lint/linter#idselector
IdSelector:
enabled: true

# Prevent usage of !important
# https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#importantrule
ImportantRule:
enabled: true

# exclude file extensions and leading underscores from imports
ImportPath:
enabled: true

Indentation:
enabled: true
character: space
width: 2

# 0.1 is more readable than .1
LeadingZero:
enabled: true
style: include_zero

# Watches for duplicated selectors and missing nesting
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#mergeableselector
MergeableSelector:
enabled: true

# Conventions around sass vars, functions, mixins
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#nameformat
NameFormat:
enabled: true

# https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#nestingdepth
NestingDepth:
enabled: false

# Probably too harsh, sometimes we might just want to extend a class
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#placeholderinextend
PlaceholderInExtend:
enabled: false

# We will never agree on this; alphas vs thematic order
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#propertysortorder
PropertySortOrder:
enabled: false

# No typos in properties
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#propertyspelling
PropertySpelling:
extra_properties:
- mso-table-lspace
- mso-table-rspace
enabled: true

# Qualifying element is an element with a selector i.e div.foo
# https://github.com/brigade/scss-lint/tree/master/lib/scss_lint/linter#qualifyingelement
QualifyingElement:
enabled: false

# Don't go deeper than 3 levels for selectors
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#selectordepth
SelectorDepth:
enabled: true

SelectorFormat:
enabled: true
convention: hyphenated_BEM

# Shorthand property descriptions
# never use a long style when shorthand will suffice
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#shorthand
Shorthand:
enabled: true

SingleLinePerProperty:
enabled: true
allow_single_line_rule_sets: false

SingleLinePerSelector:
enabled: true

SpaceAfterComma:
enabled: true

SpaceAfterPropertyColon:
enabled: true
style: one_space

SpaceAfterPropertyName:
enabled: true

SpaceBeforeBrace:
enabled: true

SpaceBetweenParens:
enabled: true
spaces: 0

# Single vs double quotes
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#stringquotes
StringQuotes:
enabled: true

TrailingSemicolon:
enabled: true

# Prevent unnecessary trailing zeros i.e. 0.5em GOOD - 0.500em BAD
# https://github.com/brigade/scss-lint/tree/master/lib/scss_lint/linter#trailingzero
TrailingZero:
enabled: true

# Numeric values should not contain unnecessary fractional portions.
# 1.0em vs 1em
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#unnecessarymantissa
UnnecessaryMantissa:
enabled: true

# Remove unecessary &
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#unnecessaryparentreference
UnnecessaryParentReference:
enabled: true

# No protocols in urls
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#urlformat
UrlFormat:
enabled: true

# Quotes around URLs
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#urlquotes
UrlQuotes:
enabled: true

# Prevent use of plain browser prefixes
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#vendorprefix
VendorPrefix:
enabled: false
excluded_identifiers: ['selection']

# Will only apply to lengths
# https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md#zerounit
ZeroUnit:
enabled: true
files:
include:
- 'src/styles/**/*.scss'
- 'src/styles/*.scss'
ignore:
- 'src/styles/settings/*.scss.liquid'
- 'src/styles/vendor/**/*.scss'
- 'src/styles/vendor/*.scss'
options:
formatter: stylish
merge-default-rules: false
rules:
border-zero: 1
brace-style:
- 1
- allow-single-line: false
class-name-format:
- 1
- convention: hyphenatedbem
clean-import-paths: 1
empty-line-between-blocks:
- 1
- ignore-single-line-rulesets: false
extends-before-declarations: 0
extends-before-mixins: 0
final-newline: 1
function-name-format: 1
hex-length:
- 1
- style: short
hex-notation:
- 1
- style: lowercase
id-name-format:
- 1
- convention: hyphenatedbem
indentation:
- 1
- size: 2
leading-zero:
- 1
- include: true
mixin-name-format: 1
mixins-before-declarations: 0
nesting-depth: 0
no-color-literals: 1
no-css-comments: 0
no-debug: 1
no-duplicate-properties: 0
no-empty-rulesets: 1
no-ids: 1
no-important: 1
no-invalid-hex: 1
no-mergeable-selectors: 1
no-misspelled-properties:
- 1
- extra-properties:
- mso-table-lspace
- mso-table-rspace
no-qualifying-elements: 0
no-trailing-zero: 1
no-url-protocols: 1
no-vendor-prefixes:
- 0
- excluded-identifiers:
- selection
placeholder-in-extend: 0
placeholder-name-format:
- 1
- convention: hyphenatedbem
property-sort-order: 0
quotes: 0
shorthand-values: 1
single-line-per-selector: 1
space-after-colon:
- 1
- include: true
space-after-comma: 1
space-before-brace: 1
space-before-colon: 1
space-between-parens:
- 1
- include: false
trailing-semicolon: 1
url-quotes: 1
variable-name-format: 1
zero-unit: 1
1 change: 0 additions & 1 deletion Gemfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ source 'https://rubygems.org'

gem 'nokogiri'
gem 'htmlentities'
gem 'scss_lint'

group :development do
gem 'pry'
Expand Down
Loading

0 comments on commit db879f4

Please sign in to comment.