-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic controls to the player #12
Conversation
7366466
to
6b4ff96
Compare
It's really nice to see some UI elements here! Thanks! You may also be interested in some of the discussion on #4, in particular regarding what Web Components might allow us to do for the UI. I would like to the move in the Web Component direction in the long run, but since that requires some refactoring work first, I'm happy to accept PRs that add UI elements like you have here in the meantime. Hopefully some parts of that work can be ported (or re-used in) to a media-chrome model. |
@englishm No problem at all! Conflicts are resolved, and play/pause functionality has been added to the play button, since the PR to add that functionality has been merged. Thanks for sharing that discussion. I will keep this direction in mind as this project continues (and hopefully contribute, as well)! Appreciate you taking a look at this one. |
bee8775
to
26ccd3e
Compare
26ccd3e
to
2a5069b
Compare
Tested, works! One minor issue I notice is that sometimes there seems to be a brief delay in responding to clicks, but I think that may be unrelated to these changes and it isn't a major issue so I'm not going to worry about it right now. (I wonder if it might be related to how we're waiting on keyframes?) Thanks for this, @christriants! I'll merge and then we can start looking at @JoaquinBCh's refactor and switch to rollup, etc. 😁 |
This PR adds basic players controls, which addresses issue #7.
We're adding a play button, volume button and track selector, replacing the controls that had been sitting below player. Each control is now its own component, and we attempted to move some logic relevant to these new components out of
watch.tsx
and to the respective component files.To test these changes:
Additionally, I renamed
usePlayer
toplayer
inwatch.tsx
. I think this is a positive change because:All feedback is welcome!