New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add volume control and UI slider #15

Merged

englishm merged 2 commits into englishm:main from JoaquinBCh:feature/volume-control

Dec 20, 2024

Contributor

JoaquinBCh commented Dec 9, 2024

Implements player volume control: unsubscribes from the audio track at volume 0, and resubscribes when volume is raised above 0.
Adds a UI slider for adjusting the volume interactively.

Grabacion.de.pantalla.desde.2024-12-09.16-38-55.webm


          feature: added volume control and UI element to test it

b3c5483

JoaquinBCh mentioned this pull request

Add Volume Control Support and UI #14

Closed

emilsas suggested changes

View reviewed changes

web/src/components/volume.tsx Outdated Show resolved Hide resolved


          fix: restore previous volume level upon unmuting

924ce07

Owner

englishm commented Dec 20, 2024

This look great, thank you!

englishm merged commit 7384056 into englishm:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet