Refactor join of workers nodes to add "join" tag #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zempashi
force-pushed
the
join_tag
branch
5 times, most recently
from
97c373c to
6a7b59d
Compare
Zempashi
force-pushed
the
join_tag
branch
2 times, most recently
from
a077846 to
160af5b
Compare
Zempashi
changed the title
Zempashi
force-pushed
the
join_tag
branch
2 times, most recently
from
8cfb6a3 to
ff610fc
Compare
Tassatux
reviewed
Jun 15, 2023
roles/upload_certs/tasks/main.yml
Outdated
| kubeadm init phase upload-certs | ||
| --upload-certs | ||
| --certificate-key {{ cert_encryption_key }} | ||
| no_log: '{{ sensitive_debug|bool }}' |
There was a problem hiding this comment.
Shouldn't this condition be negated? As we want no_log when sensitive_debug is False, not the opposite.
Zempashi
force-pushed
the
join_tag
branch
2 times, most recently
from
abb8743 to
df9ec8a
Compare
Zempashi
force-pushed
the
join_tag
branch
4 times, most recently
from
bc74e64 to
cd3fec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.