Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registration tracking events for .eth and TLD (.box) funnel #840

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Add registration tracking events for .eth and TLD (.box) funnel #840

wants to merge 35 commits into from

Conversation

nhohb
Copy link
Contributor

@nhohb nhohb commented Aug 30, 2024 •
edited by storywithoutend
Loading

  • Add tracking events to registration flow
  • Tracking events should only be called once
  • Transaction modal tracking events should only be called for the specific transaction
  • Refactor trackEvents so that it can accept a payload and is typed

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 30, 2024 •
edited
Loading

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 167aa22
Status: ✅  Deploy successful!
Preview URL: https://9490e402.ens-app-v3.pages.dev
Branch Preview URL: https://feat-fet-1177-add-registrati.ens-app-v3.pages.dev

View logs

storywithoutend
storywithoutend reviewed Aug 30, 2024
View reviewed changes
next.config.mjs Outdated Show resolved Hide resolved
storywithoutend
storywithoutend requested changes Sep 2, 2024
View reviewed changes
src/hooks/useRegistrationEventTracker.ts Outdated Show resolved Hide resolved
next.config.mjs Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
@nhohb
Revert strict mode for development, add condition for commit wallet o…
e7e4e33 
…pened and finish wallet opened tracking events
@nhohb nhohb changed the title Add registration tracking events for .eth funnel Add registration tracking events for .eth and TLD (.box) funnel Sep 5, 2024
@nhohb nhohb requested a review from makoto September 6, 2024 03:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 5, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonmanRolls LeonmanRolls LeonmanRolls approved these changes

@storywithoutend storywithoutend storywithoutend approved these changes

@makoto makoto Awaiting requested review from makoto

@sugh01 sugh01 Awaiting requested review from sugh01 sugh01 is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nhohb @makoto @LeonmanRolls @storywithoutend @sugh01