ens-test-env stops when error is thrown in script

ensdomains · Oct 15, 2024 · f401985 · f401985
1 parent 13179f2
commit f401985
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/ens-test-env/src/manager.js b/packages/ens-test-env/src/manager.js
@@ -157,6 +157,7 @@ const awaitCommand = async (name, command) => {
     deploy.stdout.pipe(outPrepender).pipe(process.stdout)
   }
   deploy.stderr.pipe(errPrepender).pipe(process.stderr)
+  deploy.stderr.on('data', cleanup.bind(null, { exit: true }))
   return new Promise((resolve) => deploy.on('exit', () => resolve()))
 }
 

diff --git a/packages/ensjs/deploy/01_delete_names.cjs b/packages/ensjs/deploy/01_delete_names.cjs
@@ -29,9 +29,6 @@ const func = async function (hre) {
     const label = labelhash(labels.shift())
     const node = namehash(labels.join('.'))
 
-    console.log("--------------- DELETE NAME ---------------")
-
-
     const tx = await registry.setSubnodeRecord(
       node,
       label,
@@ -58,6 +55,13 @@ const func = async function (hre) {
   await deleteName(name1)
   await deleteName(name2)
 
+  for (const name of [name1, name2]) {
+    const owner = await registry.owner(namehash(name))
+    if (owner !== EMPTY_ADDRESS) {
+      throw new Error(`Failed to delete name ${name}`)
+    }
+  }
+
   return true
 }