Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolinks in documentation editor #11597

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

Autolinks in documentation editor #11597

wants to merge 28 commits into from
+2,947 −2,207

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Nov 19, 2024 •
edited
Loading

Pull Request Description

Autolinks in documentation

  • Markdown editor renders autolinks (<https://example.com>).
  • Markdown editor converts URLs in pasted text to autolink syntax.
  • Markdown editor supports raw paste (Shift+Ctrl+V), which doesn't autolink.
  • Markdown parser: disable GitHub-style unmarked autolinks, and some other unsupported GFM extensions.

Stacked on #11564, #11585.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

kazcw and others added 25 commits November 14, 2024 19:31
@kazcw
Render tables in documentation.
62d8bdd 
Also:
- Separate parser for our flavor of Markdown from the CodeMirror integration;
  move the parser into ydoc-shared and use for Markdown line-wrapping.
- Introduce our own version of yCollab extension; initially just the upstream
  version translated to Typescript and our code style.
- Refactor CodeEditor.
@kazcw
CHANGELOG, prettier
40875ef
@kazcw
Apply @farmaazon review.
6bd2b95
@kazcw
Fix
c6432d0
@kazcw
Lint
be9bdd3
@kazcw
Cleanup
3d75871
@kazcw
Integration tests for GraphNodeComment
e654dfd 
Also a little refactoring in preparation for new implementation.
@kazcw
Merge remote-tracking branch 'origin/develop' into wip/kw/doc-tables
f317637
@kazcw
Workaround stuck CI
7431384
@kazcw
Merge branch 'wip/kw/node-comment-tests' into staging
58adff3
@kazcw
Merge branch 'wip/kw/doc-tables' into staging
621be55
@kazcw
CodeMirror implementation of GraphNodeComment
89cf8df 
Eliminates Lexical dependency. Stacked on #11575 and #31607.
@kazcw
Revert "Workaround stuck CI"
caaa01a 
This reverts commit 7431384.
@mergify
Merge branch 'develop' into wip/kw/node-comment-tests
4606f2b
@mergify
Merge branch 'develop' into wip/kw/doc-tables
4f8c80f
@kazcw
Revert "Workaround stuck CI"
fcac2fd 
This reverts commit 7431384.
@kazcw
Merge remote-tracking branch 'origin/wip/kw/node-comment-tests' into …
ae2b93f 
…wip/kw/doc-tables
@kazcw
Merge remote-tracking branch 'origin/develop' into wip/kw/doc-tables
c58c8b7
@kazcw
Merge branch 'wip/kw/doc-tables' into wip/kw/cm-comments
fb396d8
@kazcw
Merge remote-tracking branch 'origin/develop' into wip/kw/doc-tables
b7549bc
@kazcw
Fix merge
f11dcce
@kazcw
Merge branch 'wip/kw/doc-tables' into wip/kw/cm-comments
2583a10
@kazcw
Merge remote-tracking branch 'origin/develop' into wip/kw/doc-tables
2bdb5e8
@kazcw
LINKABLE_URL_REGEX: Remove a Lexical special case
e80de7b
@kazcw
Autolinks in documentation
d69ae37 
- Markdown editor renders autolinks (`<https://example.com>`).
- Markdown editor converts URLs in pasted text to autolink syntax.
- Markdown editor supports raw paste (Shift+Ctrl+V), which doesn't autolink.
- Markdown parser no longer supports GitHub-style unmarked autolinks.
@kazcw kazcw self-assigned this Nov 19, 2024
@kazcw kazcw marked this pull request as ready for review November 19, 2024 21:29
@kazcw kazcw requested a review from Frizi as a code owner November 19, 2024 21:29
@kazcw kazcw linked an issue Nov 19, 2024 that may be closed by this pull request
Auto-linking in documentation editor #11599
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

@MrFlashAccount MrFlashAccount Awaiting requested review from MrFlashAccount MrFlashAccount is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kazcw kazcw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-linking in documentation editor
1 participant
@kazcw