-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Cast out of Storage, new common utils for cast and unary operation. #12246
base: develop
Are you sure you want to change the base?
Conversation
Add validity checking to the converters.
Update is_a_valid_parse_target. Add test for Integer -> Boolean conversion.
Move TextLength and DateTruncate to standalone.
Will build up a base class as move forward.
(builder, index, value) -> builder.appendLong(applyObjectRow(index, value))); | ||
} | ||
|
||
protected long applyObjectRow(long index, Object value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the index argument? Struggling to find where we ever use it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the framework seemed good to have it as would allow zip operations etc in due course.
Pull Request Description
cast
fromStorage
and move to a newCastOperation
.check_cast_compatibility
delegate toCastOperation
to see if a supported conversion.StorageIterators
for building unary operations.AbstractUnary
classes.StorageIterators
.Overrides with
preseverNothing=true
and specialised versions for(map|build)Over(Long|Double|Boolean)Storage
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.