Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests that falsely assumed table ordering in DB #12248

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Fix tests that falsely assumed table ordering in DB #12248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d528aab
Fix tests that falsely assumed table ordering in DB
radeusgd Feb 6, 2025
e4ead13
Merge branch 'develop' into wip/radeusgd/fix-snowflake-tests
mergify[bot] Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/Table_Tests/src/Database/Common/Single_Column_Table_Spec.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ add_specs suite_builder (prefix : Text) setup =
t1 = table_1.get
t1.should_be_a DB_Table
(t1:DB_Column).name.should_equal "A"
(t1:DB_Column).to_vector.should_equal [1, 2, 3]
(t1:DB_Column).to_vector.should_equal_ignoring_order [1, 2, 3]
# Still has table methods
t1.column_names.should_equal ["A"]

Expand All @@ -28,7 +28,7 @@ add_specs suite_builder (prefix : Text) setup =

group_builder.specify "should allow passing the casted column to methods expecting column (with inserted cast)" <|
t1 = table_1.get
((t1:DB_Column) + (t1:DB_Column)) . to_vector . should_equal [2, 4, 6]
((t1:DB_Column) + (t1:DB_Column)) . to_vector . should_equal_ignoring_order [2, 4, 6]

group_builder.specify "should also work for DB_Tables returned from various operations" <|
t1 = table_2.get
Expand Down
Loading